Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DuplicateSearchTest #7875

Merged
merged 23 commits into from
Jul 4, 2021
Merged

Remove DuplicateSearchTest #7875

merged 23 commits into from
Jul 4, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 4, 2021

Partially reverts #7651. The test depend on localization, which causes issues when Crowdin updates arrive (see #7873).

We decided to remove it, since we need to put our limited free time into addressing functionality desires.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Siedlerchr and others added 23 commits July 4, 2021 21:11
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 4, 2021

It was working fine in main after I merged the PR! But go forward

@koppor koppor merged commit 372dec7 into main Jul 4, 2021
@koppor koppor deleted the remove-duplicate-search-test branch July 4, 2021 19:47
@koppor koppor mentioned this pull request Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants