RISImporterTest [v2] #817
Merged
RISImporterTest [v2] #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
obraliar
force-pushed
the
RISImporterTest
branch
from
9c2703d
to
61729e4
Compare
obraliar
force-pushed
the
RISImporterTest
branch
from
61729e4
to
53a3b81
Compare
|
All requested test cases from #505 have been successfully implemented. |
obraliar
force-pushed
the
RISImporterTest
branch
from
a4e8143
to
a080030
Compare
boceckts
added
the
status: ready-for-review
|
Ready to merge? |
| Assert.assertTrue(importer.isRecognizedFormat(stream)); | ||
| } | ||
| try (InputStream stream = RISImporterTest.class.getResourceAsStream("RisImporterTest2.ris")) { |
obraliar
force-pushed
the
RISImporterTest
branch
from
a080030
to
9e99a4b
Compare
|
|
||
| int referenceCount = 0; | ||
| for (int i = 0; i < risEntries.size(); i++) { | ||
| for (int j = 0; j < bibEntries.size(); j++) { |
There was a problem hiding this comment.
Wait until #982 is merged in, then a simpler BibtexEntryAssert.assertEquals() should work.
obraliar
force-pushed
the
RISImporterTest
branch
from
9e99a4b
to
58b6f44
Compare
| public class RISImporterTest { | ||
|
|
||
| RisImporter risImporter; |
|
👍 LGTM |
|
Prepare for merge (merge commits)? |
|
LGTM, too.
Finally squash all commit together then this can be merged in. |
obraliar
force-pushed
the
RISImporterTest
branch
from
267ebf6
to
fbe4d24
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.