-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present options to create an article for manual entry or return to the new entry dialog box when failed to find DOI ID ... #7870 #8203
Conversation
…n article for manual entry when the fetcher DOI failed to find an entry for an ID [JabRef#7870]
I really like the idea and the feature. This conforms to our UI strategy (refs JabRef#149). I think, the feature is not shown in our new "Entry from Id" dialog (see #8129) Could you add that feature there, too? |
Thanks for the feedback! I will try to add the feature. |
@koppor, here are screenshots of the new feature. Let me know if that is okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! LGTM from my side. One more approval from another dev and it's good to go
src/main/java/org/jabref/gui/importer/GenerateEntryFromIdAction.java
Outdated
Show resolved
Hide resolved
public StateManager stateManager() { | ||
return stateManager; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something to be injected, not to be get. Inversion of dependencies!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I passed the stateManager to the constructors instead of creating a new one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
…yTab to main branch version
No, do not create a new one, just inject it in the constructor. just like DialogService or PreferencesService |
@mrcstan Thank you for your contribution! We are look forward to more! |
Fixes stuck-in-library issue when the fetcher DOI failed to find an entry for an ID #7870. User can now choose to add entry manually instead of returning to the new entry dialog box
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)