Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NegativeArraySizeException #8270

Merged
merged 5 commits into from
Nov 25, 2021
Merged

Fix NegativeArraySizeException #8270

merged 5 commits into from
Nov 25, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 22, 2021

Fixes #8231
Fixes #8265

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft November 22, 2021 22:12
@koppor
Copy link
Member Author

koppor commented Nov 22, 2021

This is sort of a quick fix. Rethinking following line of code

intention - fieldName.length()

leads to the conclusion that the indent is incorrectly calculated in some settings

@koppor
Copy link
Member Author

koppor commented Nov 25, 2021

No user showed up here. Since this fix ensures that StringUtils.repeat works also with negative parameters, I am marking as "ready for review".

@koppor koppor marked this pull request as ready for review November 25, 2021 20:18
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we don't know the root cause, it's better than nothing!

@Siedlerchr Siedlerchr merged commit 7ec4c7e into main Nov 25, 2021
@Siedlerchr Siedlerchr deleted the fix-8265 branch November 25, 2021 22:14
Siedlerchr added a commit that referenced this pull request Nov 28, 2021
* upstream/main:
  Fix NegativeArraySizeException (#8270)
Siedlerchr added a commit that referenced this pull request Nov 30, 2021
* upstream/main:
  Consider directory pattern when checking if a file can be moved (#8244)
  Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285)
  Bump unirest-java from 3.13.3 to 3.13.4 (#8283)
  Bump checkstyle from 9.1 to 9.2 (#8284)
  Bump classgraph from 4.8.135 to 4.8.137 (#8282)
  Do not resize main table columns in search dialog window (#8253)
  Fix NegativeArraySizeException (#8270)
  Update deployment.yml
  TEst
  Grand unified library properties (GRULPS) (#8264)
  Fixes RFC fetcher test case (#8271)
  Update Gradle Wrapper from 7.2 to 7.3 (#8246)
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  Bump mockito-core from 4.0.0 to 4.1.0 (#8267)
  Bump classgraph from 4.8.130 to 4.8.135 (#8268)
  Fix some fetcher tests (#8258)
  Clicking a DOI link in the preview pane no longer crashes (#8255)
Siedlerchr added a commit that referenced this pull request Dec 4, 2021
* upstream/main: (259 commits)
  Fix exception on preview style edit and selection (#8293)
  Fix icon picker excpetion in groups dialog (#8290)
  Add doc tests (#8242)
  fix merge conflict
  Squashed 'buildres/csl/csl-locales/' changes from 0cc3885f61..d5ee85de8e
  Squashed 'buildres/csl/csl-styles/' changes from 3a6a0a7..3bb4b5f
  Consider directory pattern when checking if a file can be moved (#8244)
  Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285)
  Bump unirest-java from 3.13.3 to 3.13.4 (#8283)
  Bump checkstyle from 9.1 to 9.2 (#8284)
  Bump classgraph from 4.8.135 to 4.8.137 (#8282)
  Do not resize main table columns in search dialog window (#8253)
  Fix NegativeArraySizeException (#8270)
  Update deployment.yml
  TEst
  Grand unified library properties (GRULPS) (#8264)
  Fixes RFC fetcher test case (#8271)
  Update Gradle Wrapper from 7.2 to 7.3 (#8246)
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NegativeArraySizeException on saving NegativeArraySizeException when editing and saving a @Reference entry
2 participants