Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable preferences I (Internal [formerly Version], Groups, Xmp, AutoComplete) #8336

Merged
merged 6 commits into from
Dec 26, 2021

Conversation

calixtus
Copy link
Member

Follow up to #8260

Note: enabling autocomplete without restarting probably requires a major refactor of the entry editor. As I believe that this would escalate this PR too much, I think we should leave this for later, maybe when the entry editor is redesigned.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions labels Dec 14, 2021
}
EasyBind.subscribe(preferencesService.getGroupsPreferences().displayGroupCountProperty(),
(newValue) -> {
if (text.textProperty().isBound()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? Please add a comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot set the text to an empty value if the value is bound, instead it keeps the last calculated number of entries in group.getHits() or just 0, if the preference option to calculate the number of entries (which is very expensive in large databases) is deactivated. If the calculation of entries is disabled and you add or remove an entry from a group it would display the wrong number of entries.

@Siedlerchr Siedlerchr merged commit ba5beb2 into main Dec 26, 2021
@Siedlerchr Siedlerchr deleted the xmpprefs-refactor branch December 26, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants