Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file directory preferences not respected #8429

Merged
merged 3 commits into from
Jan 16, 2022
Merged

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 14, 2022

Fixes #8385

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr requested a review from calixtus January 14, 2022 21:19
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 14, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/org/jabref/preferences/FilePreferences.java Outdated Show resolved Hide resolved
Siedlerchr and others added 2 commits January 16, 2022 16:32
Check in getFileDirectory logic
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@Siedlerchr
Copy link
Member Author

I updated the logic

@Siedlerchr Siedlerchr merged commit 88773cc into main Jan 16, 2022
@Siedlerchr Siedlerchr deleted the fixFileDirNotChanges branch January 16, 2022 18:06
Siedlerchr added a commit that referenced this pull request Jan 21, 2022
* upstream/main: (50 commits)
  New Crowdin updates (#8451)
  Fix library tab exception when saving prefs (#8450)
  Rename Groups interface into Groups (#8449)
  New Crowdin updates (#8445)
  update snap url
  Update bug_report.yml for 5.5
  Show development information\n\n+semver: minor
  Release v5.5
  Update journal abbrev list
  New Crowdin updates (#8439)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 5563ccc..0237ae7
  Fixed add group button changing color after adding 10 groups (#8392)
  Bump slf4j-api from 2.0.0-alpha5 to 2.0.0-alpha6 in /buildSrc (#8438)
  Bump libreoffice from 7.2.3 to 7.2.5 (#8436)
  Bump org.openjfx.javafxplugin from 0.0.10 to 0.0.11 (#8437)
  Fix file directory preferences not respected (#8429)
  Refresh example styles
  Squashed 'buildres/csl/csl-locales/' changes from c38205618f..4a551a87c3
  Refresh example styles
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linked files preference ignored when changed
2 participants