Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications that overlap task bar #8775

Merged
merged 10 commits into from
May 15, 2022
+14 −5
Merged

Fix notifications that overlap task bar #8775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed8e933
Fix notifications that overlap task bar by adding threshold
LIM0000 May 9, 2022
9446712
Fix notifications that overlap bottom task bar by setting window owner
LIM0000 May 10, 2022
013add6
Update fixes from using dependancy injection, localize language of no…
LIM0000 May 10, 2022
7c31e1a
Merge branch 'main' of https://github.com/LIM0000/jabref into fix-for…
LIM0000 May 14, 2022
ea8267e
Update collapsed notification and add keys into l10n file
LIM0000 May 14, 2022
311a9e9
Merge remote-tracking branch 'origin/main' into fix-for-issue-8769
koppor May 15, 2022
26f0cbc
Work on text
koppor May 15, 2022
00b2ef8
Merge remote-tracking branch 'upstream/main' into fix-for-issue-8769
Siedlerchr May 15, 2022
9253a99
Adjut text
Siedlerchr May 15, 2022
a4443c3
checkstyle and l10n
Siedlerchr May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/main/java/org/jabref/gui/JabRefDialogService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,18 @@ public void notify(String message) {

DefaultTaskExecutor.runInJavaFXThread(() -> {
Notifications.create()
.text(message)
.position(Pos.BOTTOM_CENTER)
.hideAfter(TOAST_MESSAGE_DISPLAY_TIME)
.hideCloseButton()
.show();
.text(message)
.position(Pos.BOTTOM_CENTER)
.hideAfter(TOAST_MESSAGE_DISPLAY_TIME)
.owner(mainWindow)
.threshold(5,
Notifications.create()
.title(Localization.lang("Last notification"))
.text(
"(" + Localization.lang("Check the event log to see all notifications") + ")"
+ "\n\n" + message))
.hideCloseButton()
.show();
});
}

Expand Down
2 changes: 2 additions & 0 deletions src/main/resources/l10n/JabRef_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,6 +1668,8 @@ Issue\ report\ successful=Issue report successful
Your\ issue\ was\ reported\ in\ your\ browser.=Your issue was reported in your browser.
The\ log\ and\ exception\ information\ was\ copied\ to\ your\ clipboard.=The log and exception information was copied to your clipboard.
Please\ paste\ this\ information\ (with\ Ctrl+V)\ in\ the\ issue\ description.=Please paste this information (with Ctrl+V) in the issue description.
Last\ notification=Last notification
Check\ the\ event\ log\ to\ see\ all\ notifications=Check the event log to see all notifications

Host=Host
Port=Port
Expand Down