Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #8288 Move search button of web search elsewhere #8799

Closed
wants to merge 2 commits into from

Conversation

Yancy10-1
Copy link

@Yancy10-1 Yancy10-1 commented May 15, 2022

Move search button of web search elsewhere

fixes #8288

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Screenshots:
qjVuX.jpg

Move search button of web search elsewhere
@ThiloteE ThiloteE added the ui label May 16, 2022
@calixtus
Copy link
Member

Thanks for your pull request and your work. @ThiloteE already mentioned a good rationale in the corresponding issue i can only agree too. However, we will nevertheless discuss your proposal in the next devall and make a final decision on this PR.

@koppor
Copy link
Member

koppor commented May 23, 2022

Thank you for the first time contribution.

JavaFX is a long and rocky roard. The proposed button is NOT aligned with the search field:

grafik

In the DevCall, we decided to keep the UI as is.

For further pull requests, please setup your JabRef environment as described at https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#using-jabrefs-code-style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move search button of web search elsewhere
4 participants