Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge entries should be able to merge keywords #8983

Closed
wants to merge 1 commit into from

Conversation

YANG-CY-163
Copy link

@YANG-CY-163 YANG-CY-163 commented Jul 15, 2022

Fixes JabRef#12

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member

koppor commented Jul 18, 2022

@YANG-CY-163 Thank you for starting working on this.

Please investigate following issues:

  • The merging of keywords is some kind of logic. That should not happen in the UI. Please create a method static KeywordList merge(KeywordList other) {} (in org.jabref.model.entry.KeywordList) returning a new KeywordList
  • There need be test cases for merging keywords. Create some test methods in org.jabref.model.entry.KeywordListTest

Since another contributor works on the UI, you can stop implementing something in the UI. Please open a new branch addKeywordMerge from JabRef:main and just implement the above methods. Then, open a new PR. Then, close this PR.

Nevertheless, please add a screenshot of your new dialog so the community can benefit from your idea.

@koppor koppor closed this Jul 18, 2022
@koppor koppor reopened this Jul 18, 2022
@koppor koppor marked this pull request as draft July 18, 2022 18:33
@Siedlerchr
Copy link
Member

Superseded by #9022

@Siedlerchr Siedlerchr closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge entries should be able to merge keywords and groups
4 participants