Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RfcFetcherTest #8988

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Fix RfcFetcherTest #8988

merged 3 commits into from
Jul 18, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 18, 2022

This PR fixes the fetcher tests

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor and others added 3 commits July 18, 2022 20:16
@koppor @Siedlerchr
@calixtus @btut
Fix RfcFetcherTest
988fc56 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Benedikt Tutzer <btut@users.noreply.github.com>
@koppor @Siedlerchr
@calixtus @btut
Fix JstorFetcherTest
b4b2108 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Benedikt Tutzer <btut@users.noreply.github.com>
@koppor @Siedlerchr
@calixtus @btut
Disable CiteSeerTest
dce9dc2 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Benedikt Tutzer <btut@users.noreply.github.com>
@koppor koppor marked this pull request as ready for review July 18, 2022 18:51
@koppor koppor merged commit 126c1c3 into main Jul 18, 2022
@koppor koppor deleted the fix-fetchers branch July 18, 2022 18:51
Siedlerchr added a commit to zkl-ai/jabref that referenced this pull request Jul 19, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into improve-DOI-import-…
b8a83ac 
…failure-dialog

* upstream/main:
  Reworded t in pr (JabRef#8989)
  Fixed checkstyle (JabRef#8990)
  Fix RfcFetcherTest (JabRef#8988)
  Fixes JabRef#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982)

# Conflicts:
#	src/main/java/org/jabref/gui/maintable/MainTable.java
#	src/test/java/org/jabref/logic/importer/fetcher/JstorFetcherTest.java
Siedlerchr added a commit to Ognimalf/jabref that referenced this pull request Jul 29, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into Ognimalf/main
13c0fa8 
* upstream/main:
  Autosave folder and checkbox is remembered (JabRef#9000)
  New Crowdin updates (JabRef#8999)
  Sync group view mode and main table (JabRef#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (JabRef#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (JabRef#8997)
  Bump java-diff-utils from 4.11 to 4.12 (JabRef#8998)
  Fix external group metadata changes are not merged (JabRef#8994)
  New Crowdin updates (JabRef#8995)
  Reworded t in pr (JabRef#8989)
  Fixed checkstyle (JabRef#8990)
  Fix RfcFetcherTest (JabRef#8988)
  Fixes JabRef#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btut btut btut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @btut