Skip to content

Fixing capitalization in words with any dashes #9101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

jvsdurso
Copy link

@jvsdurso jvsdurso commented Aug 28, 2022

Fixes #9068

What: Fixing capitalization after dashes. Also covering zero width spaces. Tests were implemented too.

Why: To solve the issue #9068

Context: I'm having some classes about TDD (Test-Driven Development) and we were asked to solve an issue from JabRef. I chose to work on this one.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Implementation of Multiple Condition Coverage (MCC) for isNumber method in NumericFieldComparator class
@jvsdurso jvsdurso changed the title Fix for issue 9068 Fixing capitalization in words with any dashes Aug 28, 2022
@calixtus
Copy link
Member

calixtus commented Aug 29, 2022

Please provide the issue number, this pr fixes.

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jvsdurso , that is for you interest in jabref.
However I noticed some issues.

  • changelog entry is only needed once.
  • since java18 the idk works completely with utf 8. So you could probably use clear Unicode text instead of escaped characters. That would improve the readability a lot.
  • also the tests seem to be very similar and probably could be parameterized.

@jvsdurso
Copy link
Author

Hi @jvsdurso , that is for you interest in jabref. However I noticed some issues.

  • changelog entry is only needed once.
  • since java18 the idk works completely with utf 8. So you could probably use clear Unicode text instead of escaped characters. That would improve the readability a lot.
  • also the tests seem to be very similar and probably could be parameterized.

Changes were made. I think leaving the tests with zero width spaces in Unicode may be better for visualization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

title case may be no right when the en-dash exist in title
2 participants