Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index-creation #9132

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Fix index-creation #9132

merged 1 commit into from
Sep 4, 2022

Conversation

btut
Copy link
Contributor

@btut btut commented Sep 4, 2022

Commit d8b48dd introduced a bug that
prohibited the fulltext-indexer to start.
It now uses the OpenDatabaseAction that does not trigger the indexing
listener. This suggests that openinga new library never triggered an
index-creation as that always used that action.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Commit d8b48dd introduced a bug that
prohibited the fulltext-indexer to start.
It now uses the OpenDatabaseAction that does not trigger the indexing
listener. This suggests that openinga new library never triggered an
index-creation as that always used that action.
@Siedlerchr Siedlerchr merged commit 6d856b6 into main Sep 4, 2022
@Siedlerchr Siedlerchr deleted the fixIndexingAfterBackupManager branch September 4, 2022 15:52
Siedlerchr added a commit that referenced this pull request Sep 4, 2022
* upstream/main:
  Resimplify Action interface (#9133)
  Fix issue with empty fallback directory (#9134)
  Fix indexing (#9132)
  SLR data is now editable (#9131)
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Sep 10, 2022
* upstream/main:
  Anomaly with Title case and Sentence case JabRef#9112 (JabRef#9142)
  Fixed save order config (JabRef#9148)
  Update devdocs about fetchers (JabRef#9146)
  Set 'Update refused' dialog title (JabRef#9143)
  Bump jackson-datatype-jsr310 from 2.13.3 to 2.13.4 (JabRef#9136)
  Bump jackson-dataformat-yaml from 2.13.3 to 2.13.4 (JabRef#9138)
  Observable Preferences N (PushToApplicationPreferences, ExternalApplicationPreferences) (JabRef#9135)
  Resimplify Action interface (JabRef#9133)
  Fix issue with empty fallback directory (JabRef#9134)
  Fix indexing (JabRef#9132)
  SLR data is now editable (JabRef#9131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants