Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition #9255

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition #9255

merged 4 commits into from
Oct 19, 2022

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 15, 2022 •
edited by ThiloteE
Loading

Follow up to #8607

This follow up was necessary because of citation-style-language/styles#6255

  • adds apa.csl for test
  • fixes tests
  • adds mapping as javadoc comment
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
WIP Adjust CSL mapping for Apa 7
51b4ed6 
add apa.csl for test
@ThiloteE ThiloteE changed the title WIP Adjust CSL mapping for Apa 7 [WIP] Adjust CSL mapping for Apa 7 Oct 18, 2022
Siedlerchr and others added 3 commits October 18, 2022 19:59
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into apa7number
9805832 
* upstream/main:
  Removed swing from default file dir detection (#9222)
  Make autosave tick in shared database opening dialog active (#9258)
  Bump controlsfx from 11.1.1 to 11.1.2 (#9261)
  Bump actions/configure-pages from 1 to 2 (#9262)
  Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259)
  Bump gittools/actions from 0.9.13 to 0.9.14 (#9260)
@Siedlerchr @ThiloteE
Fix tests as csl apa 7 now has number field
9832393 
Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@Siedlerchr @ThiloteE
Add documentation
87fa919 
Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@Siedlerchr Siedlerchr changed the title [WIP] Adjust CSL mapping for Apa 7 Adjust CSL mapping for Apa 7 Oct 18, 2022
@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers hacktoberfest-accepted labels Oct 18, 2022
@ThiloteE ThiloteE changed the title Adjust CSL mapping for Apa 7 Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition Oct 19, 2022
@Siedlerchr Siedlerchr merged commit b969f6f into main Oct 19, 2022
@Siedlerchr Siedlerchr deleted the apa7number branch October 19, 2022 18:19
Siedlerchr added a commit that referenced this pull request Oct 21, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-9221
55303f1 
* upstream/main: (28 commits)
  Minor code improvements in library properties dialog (#9265)
  Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (#9255)
  Removed swing from default file dir detection (#9222)
  Make autosave tick in shared database opening dialog active (#9258)
  Bump controlsfx from 11.1.1 to 11.1.2 (#9261)
  Bump actions/configure-pages from 1 to 2 (#9262)
  Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259)
  Bump gittools/actions from 0.9.13 to 0.9.14 (#9260)
  Fix for resizing cleanup entries dialog (#9240)
  Refresh example styles
  Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390
  Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a
  Fix casing
  Update contributing.md
  Remove obsolete Jekyll howto
  Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (#9249)
  Place subgroups w.r.t. alphabetical ordering (#9228)
  DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229)
  ISSUE-9145: implement isbn fetcher (#9205)
  Remove explicit javafx jmod stuff (#9245)
  ...
Siedlerchr added a commit to TheGor1lla/jabref that referenced this pull request Oct 21, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-9214
d49632a 
* upstream/main:
  [WIP] Add GitHub action: Greetings.yml - Automates advice to JabRefs first time code contributors (JabRef#9272)
  Minor code improvements in library properties dialog (JabRef#9265)
  Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (JabRef#9255)
  Removed swing from default file dir detection (JabRef#9222)
  Make autosave tick in shared database opening dialog active (JabRef#9258)
  Bump controlsfx from 11.1.1 to 11.1.2 (JabRef#9261)
  Bump actions/configure-pages from 1 to 2 (JabRef#9262)
  Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (JabRef#9259)
  Bump gittools/actions from 0.9.13 to 0.9.14 (JabRef#9260)
  Fix for resizing cleanup entries dialog (JabRef#9240)
  Refresh example styles
  Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390
  Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a
  Fix casing
  Update contributing.md
  Remove obsolete Jekyll howto
  Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (JabRef#9249)
  Place subgroups w.r.t. alphabetical ordering (JabRef#9228)
  DOAB Fetcher now fetches ISBN and imprint fields where possible (JabRef#9229)
Siedlerchr added a commit that referenced this pull request Oct 21, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into testmain
b9a3292 
* upstream/main:
  [WIP] Add GitHub action: Greetings.yml - Automates advice to JabRefs first time code contributors (#9272)
  Minor code improvements in library properties dialog (#9265)
  Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (#9255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ThiloteE ThiloteE

Labels
component: entry-preview status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @ThiloteE