-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 8747: date field change causes an uncaught exception #9314
Conversation
…s not in format" This reverts commit bd8f8c3.
…erences to the calling of DataEditor in FieldEditors
That is a nice improvement. Regarding invalid inputs, as biblatex supports a couple of more dates, see also #9310 ) can you try to integrate this with JabRef's date time parsing class? And please take a look at the reviewdog output (Files changed tab) |
Hello, could you help have a look at the new change by adding Date integration to the default string converter? I think the string converter provided by |
@@ -36,7 +36,7 @@ public TemporalAccessor fromString(String string) { | |||
if (StringUtil.isNotBlank(string)) { | |||
try { | |||
return dateFormatter.parse(string); | |||
} catch (DateTimeParseException exception) { | |||
} catch (Exception exception) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this to a generic exception? Exception should be always the most specfic one
I tested your PR and it looks good so far. Please have a look at the failing checkstyle tests and also the exception handling. |
Fixes #8747
Short Description
In library mode "biblatex", when user edits the entry's "date" field with an invalid input and clicks somewhere, an uncaught exception of null pointer occurs.
Checklist
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)UI changes (takes time to load gif images)
Before
Type invalid inputs: nothing happen
Click somewhere: an exception occured;
Press Enter: input disappears
After
Type invalid inputs: show warning icon
Click somewhere: nothing happens
Press Enter: input disappears