Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable Preferences Q (BibEntryPreferences) #9442

Merged
merged 9 commits into from
Dec 18, 2022
Merged

Observable Preferences Q (BibEntryPreferences) #9442

merged 9 commits into from
Dec 18, 2022

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Dec 11, 2022

Follow up to #9422

Got a bit messy and mixed up, because the getKeywordDelimiter was very thin spreaded throughout many parts of the code. Review is probably easiest commit by commit.

  • Cleaned up some preference migrations
  • Introduced preferences tab 'Entry' and reordered some preferences into it from 'General' (idea is to dissolve general tab eventually and reorder its contents into other preferences, like language into appearance etc.; collect clusters of preferences like entry preview+entry table+entry editor+editor tabs or entry+group+key generator, etc.)

Entry tab:
grafik

General tab:
grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers dev: code-quality Issues related to code or architecture decisions component: preferences labels Dec 11, 2022
@calixtus calixtus changed the title Refactored prefs migrations Observable Preferences Q (BibEntryPreferences) Dec 11, 2022
@Siedlerchr
Copy link
Member

Keyword parser test is failing.. I would like to not integrate this into 5.8 but in 6.0 or so

@Siedlerchr Siedlerchr added this to the v6.0 milestone Dec 12, 2022
# Conflicts:
#	CHANGELOG.md
#	src/main/java/org/jabref/gui/dialogs/BackupUIManager.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: preferences dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants