Update MacOS jabrefHost.py to find local installs #9487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following issue [9474](JabRef#9474). The previous MacOS hardcoded path fails if JabRef is installed to a users local applications directory rather than the system one (e.g. if the user doesn't have admin permissions). On my version of MacOS (12.6.1) this change works correctly for local installs as well. The Mac app bundle is structured differently so an alternate path is still required. If the difference in `which` behaviour is still a problem (maybe on older versions?) the original hardcoded fallback could also be included as a final option. If that is still necessary the explanatory comment should be updated too. As mentioned on the issue thread the python script path in the browser extension JSON would still need to be updated for local installs, so I will submit a separate PR to the docs with notes on the process. If this script can't be updated I can expand the docs update to detail the hardcoded path change required to make the browser extension work for local app installs.
|
This change looks good to me! |
|
This seems good to me. MacOS has paths that are easily hardcoded |
This comment was marked as off-topic.
This comment was marked as off-topic.
Siedlerchr
added
the
status: ready-for-review
|
Thanks again, as we came to the conclusion that this is fine we merge it now |
Siedlerchr
added a commit
to rafatd/jabref
that referenced
this pull request
Dec 21, 2022
…of_groups_to_new_library * upstream/main: Update MacOS jabrefHost.py to find local installs (JabRef#9487)
Siedlerchr
added a commit
to shafinkamal/jabref
that referenced
this pull request
Dec 21, 2022
* upstream/main: (145 commits) Enable groups drag'n'drop to new library (JabRef#9460) Update MacOS jabrefHost.py to find local installs (JabRef#9487) Fix remember last open valid library with empty new one (JabRef#9489) Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486) Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485) New Crowdin updates (JabRef#9483) Add log for ignored excepton (JabRef#9302) Select Library to import into (JabRef#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release ... # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/preferences/JabRefPreferences.java
Siedlerchr
added a commit
to Freeman6475/jabref
that referenced
this pull request
Dec 22, 2022
* upstream/main: (120 commits) Enable groups drag'n'drop to new library (JabRef#9460) Update MacOS jabrefHost.py to find local installs (JabRef#9487) Fix remember last open valid library with empty new one (JabRef#9489) Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486) Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485) New Crowdin updates (JabRef#9483) Add log for ignored excepton (JabRef#9302) Select Library to import into (JabRef#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release ...
Siedlerchr
added a commit
that referenced
this pull request
Dec 25, 2022
* upstream/main: (75 commits) Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493) Enable groups drag'n'drop to new library (#9460) Update MacOS jabrefHost.py to find local installs (#9487) Fix remember last open valid library with empty new one (#9489) Observable Preferences R (CitationKeyPatternPreferences) (#9486) Fixed ZBMathTest and extracted keyWordSeparator (#9485) New Crowdin updates (#9483) Add log for ignored excepton (#9302) Select Library to import into (#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (#9478) Bump mockito-core from 4.9.0 to 4.10.0 (#9479) Bump checkstyle from 10.4 to 10.5.0 (#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (#9480) Bibtex month not deprecated (#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9474
The previous MacOS hardcoded path fails if JabRef is installed to a users local applications directory rather than the system one (e.g. if the user doesn't have admin permissions). On my version of MacOS (12.6.1) and python (3.9.6) this change works correctly for local installs as well as global. The Mac app bundle is structured differently so an alternate path is still required.
If the difference in
whichbehaviour is still a problem (maybe on older versions/different python versions?) the original hardcoded fallback could also be included as a final option. If that is still necessary the explanatory comment should be updated too, as should the docs to detail when the hardcoded fallback is needed and therefore when users may need to manually update it.As mentioned on the issue thread the python script path in the browser extension JSON would still need to be updated for local installs, so I will submit a separate PR to the docs with notes on the process. If this script can't be updated I can expand the docs update to detail the hardcoded path change required to make the browser extension work for local app installs.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)