Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not on fx thread error when downloading file #9522

Merged
merged 6 commits into from
Jan 3, 2023
Merged

Fix not on fx thread error when downloading file #9522

merged 6 commits into from
Jan 3, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 3, 2023 •
edited
Loading

Fixes #9521

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2023
calixtus
calixtus previously approved these changes Jan 3, 2023
View reviewed changes
Siedlerchr and others added 2 commits January 3, 2023 23:46
@Siedlerchr
Merge branch 'fixFxThreadException' of github.com:JabRef/jabref into …
48c38d7 
…fixFxThreadException

* 'fixFxThreadException' of github.com:JabRef/jabref:
  Refine test output
  Update CHANGELOG.md
@koppor
Add missing dots
1e8e995
@calixtus calixtus merged commit 4a4502d into main Jan 3, 2023
@calixtus calixtus deleted the fixFxThreadException branch January 3, 2023 23:04
Siedlerchr added a commit to NiD133/jabref that referenced this pull request Jan 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into get_full_text
5448d36 
* upstream/main: (29 commits)
  Use Set instead of List for custom journal abbreviations (JabRef#9515)
  Delete snap.yml (JabRef#9526)
  New Crowdin updates (JabRef#9523)
  Fix not on fx thread error when downloading file (JabRef#9522)
  Fix downloading in case of circular redirect (JabRef#9519)
  Typo: sucess -> success (JabRef#9520)
  New Crowdin updates (JabRef#9517)
  Add CHANGELOG.md entry for 9472
  Fix journal abbbrev checker for curly braces (JabRef#9504)
  Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511)
  Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513)
  Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512)
  Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514)
  Create a better solution for define multi line fields (JabRef#9456)
  Check links once a month
  Really ignore CHANGELOG.md in link check
  Fix spaces
  Add missing dots
  Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
  try to repack deb file (JabRef#9506)
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
Siedlerchr added a commit to koppor/jabref that referenced this pull request Jan 5, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into restapi
4638d77 
* upstream/main: (244 commits)
  Use Set instead of List for custom journal abbreviations (JabRef#9515)
  Delete snap.yml (JabRef#9526)
  New Crowdin updates (JabRef#9523)
  Fix not on fx thread error when downloading file (JabRef#9522)
  Fix downloading in case of circular redirect (JabRef#9519)
  Typo: sucess -> success (JabRef#9520)
  New Crowdin updates (JabRef#9517)
  Add CHANGELOG.md entry for 9472
  Fix journal abbbrev checker for curly braces (JabRef#9504)
  Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511)
  Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513)
  Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512)
  Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514)
  Create a better solution for define multi line fields (JabRef#9456)
  Check links once a month
  Really ignore CHANGELOG.md in link check
  Fix spaces
  Add missing dots
  Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
  try to repack deb file (JabRef#9506)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
entry-editor fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not on FX Thread when downloading file
4 participants
@Siedlerchr @koppor @calixtus @ThiloteE