Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Fetcher for Bibliotheksverbund Bayern with MarcXML parser #9641

Merged
merged 28 commits into from
Mar 13, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Feb 27, 2023

This pr provides a new fetcher for the "Bibliotheksverbund Bayern" and an experimental parser for the LoC standard MarcXML for in a 'bavarian flavor'. Much room for improvement, but basic functionality already available.

There are some ToDos left for a followup PR:

  • pages
  • volume and number in proceedings
  • distinguish between journals, thesis, proceedings and books
  • decide how to work with notes in tag numbers 546-599

See also:

Sadly the Bibliotheksverbund Bayern seems not to understand SRU as described in the standard and parse the conjunctions AND and OR correctly. Or I did something wrong.

Proposal is to merge this one, make it testable and maybe someone is interested to finish this, as this demands a lot of testing and not so much coding.

Also renamed GvKParser to PicaXmlParser, since GvK is the bibliographic service provider and PicaXML is the data format si it is consistent with BvbFetcher and MarcXmlParser.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor merged commit 8958e8b into main Mar 13, 2023
@koppor koppor deleted the add-marcxml-fetcher branch March 13, 2023 20:55
Siedlerchr added a commit that referenced this pull request Mar 14, 2023
…rg.mariadb.jdbc-mariadb-java-client-3.1.0

* upstream/main: (357 commits)
  Fix syntax
  Add experimental Fetcher for Bibliotheksverbund Bayern with MarcXML parser (#9641)
  Update guidelines-for-setting-up-a-local-workspace.md
  Update guidelines-for-setting-up-a-local-workspace.md
  Bump org.tinylog:slf4j-tinylog from 2.6.0 to 2.6.1 (#9665)
  Bump apple-actions/import-codesign-certs from 1 to 2 (#9662)
  Bump com.puppycrawl.tools:checkstyle from 10.8.0 to 10.8.1 (#9661)
  Bump gittools/actions from 0.9.15 to 0.10.2 (#9663)
  Bump hmarr/auto-approve-action from 3.1.0 to 3.2.0 (#9664)
  Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 (#9666)
  Bump org.tinylog:tinylog-api from 2.6.0 to 2.6.1 (#9667)
  Add option to open arks in the browser from an ark identifier (#9601)
  remove "jdk 19 does not work" (#9658)
  Fulltext fetcher for IACR eprints (#9651)
  Observable Preferences S (#9619)
  Issue 9646: Right-click context menu "Attach file from URL" (#9648)
  Improve the INSPIREFetcher in "Update with bibliographic information from the web" (#9645)
  Bump appleboy/ssh-action from 0.1.7 to 0.1.8 (#9653)
  Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9656)
  Bump com.puppycrawl.tools:checkstyle from 10.7.0 to 10.8.0 (#9655)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants