-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grobid config panel without checkbox #9802
Conversation
The PR currently worked on is #9801 |
I have continued working on this branch since it does not have the checkbox. I agree with Tobias' s comment #9291 (comment). So I have changed the behavior this way: With the first import this dialog is displayed Depending on the answer, set the preference to "enable" or "disabled".(yes in the case) Thereafter, the user will not be asked again unless he resets preferences. |
I double checked the casing of They say, "Grobid" is also OK. (Source: https://github.com/kermitt2/grobid#grobid-documentation) Sorry for my wrong demand for "GROBID" I noticed the inconsistency here: |
Please address the comments by @calixtus from the PR #9801 (comment) After our discussions here, issue refinements, the task is different:
There is already the boolean setting.
Instead of "Do not ask again", the dialog should only appear upon first start ever in JabRef. This should be recorded in the preferences. I think, we need a new preference key (internal storage) for that. In that way, no migration is necessary. (Adressing the comment #9801 (comment)) |
I am implementing the preferences in the tab directly now. However, I faced a problem when I was running the tests. Some tests(Tests/Unit tests) failed because I am working on Windows so paths are not recognized which caused the failure of the test. |
If you push your changes to GitHub, we can see your changes and maybe help. Please also merge the current main branch into your brach, since we just recently hat a major change in the preferences UI. The Importexport tab has been dissolved and it's content moved to other panels. |
Closing this PR due to inactivity 💤 |
This fixes a koppor issue #566 related to Grobid preferences.The link:
Fixes koppor#566 .
I have changed Grobid preferences from a checkbox to a Radio-Button-Group (disable, enable, always ask).
This is the new configuration panel
The dialog below appears as long as the user does not check "do not ask again" or change preferences .
Despite the decision as mentioned here koppor#566 (comment) was to remove the "do not ask checkbox", I think it is not recommended from a UX perspective. So, I provided two versions: the branch: "gorbidConfigPanel" without a checkbox and the branch"gorbidConfigPanelWithCheckBox" with a checkbox.
The checkbox in the later branch is synchronized so when it is checked Grobid preferences will be "disabled" or "enabled" according to the user's answer(yes/no).
Compulsory checks