DB properties layout and save order config changed #999
Conversation
|
|
||
| FieldFormatterCleanup action = saveActions.remove(index); | ||
| if ((index >= 0) && (index < saveActions.size())) { |
There was a problem hiding this comment.
Shouldn't the error message just be logged or is it often the case that the index parameter is given "out of bounds"?
There was a problem hiding this comment.
It is always the case when you click the button and nothing is selected in the ListBox or you just deleted the last entry.
So I thought: Nothing selected/nothing to remove -> Do nothing
|
Is it possible to write a simple UI test for it? 😇 Refs #507 |
|
UI-Test, I will try to write one |
|
Added GUI Test und fixed Checkbox label not displaying correclty |
koppor
added
component: ui
status: ready-for-review
|
The code looks good, so I give my 👍 for merging if you add a nice looking screenshot 😃 |
|
@tobiasdiez Here you are: |
| FormBuilder builder = FormBuilder.create().layout(new FormLayout("left:pref, 4dlu, left:pref, 4dlu, pref:grow", | ||
| "pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 2dlu, pref, 140dlu, pref,")); | ||
| setupSortOrderConfiguration(); | ||
| FormLayout form = new FormLayout("left:pref, 4dlu, left:pref, 4dlu, pref:grow", |
There was a problem hiding this comment.
Change the grow to the third column? Now, the browse button is resized. better if the text field is resized.
|
@oscargus From this one it sounded very simple: http://alvinalexander.com/java/edu/jgoodies-formlayout-grow-fill/3-fixing-jgoodies-formlayout-sizing.shtml |
|
My code did everything except horizontal sizing (and I also tried a
lot...), so check there for possible hints. I think that when spanning
multiple columns using a fourth alignment argument to .xyw is one thing.
|
|
@Siedlerchr : I think it is good to go, so please rebase and it can be merged. (I reserve the right to fix/change(?) the scaling at some stage. :-)) |
|
@oscargus Okay, otherwise I would have looked at the GUI resizing in more detail the next days |
|
@Siedlerchr Up to you. I just wasn't sure what the status of the PR was and was thinking of merging it (if it was possible). Feel free to look at the resizing. 👍 |
oscargus
removed
the
status: ready-for-review
… border Changed JComboxBox to editable and removed the unnecessary textfields Added JCombobox for selecting the fields to apply the selected formatter to Changed position of Delete Button Removed IndexOutOfBound Exception when no item is selected
|
@oscargus As I just rebased it on the master I would suggest merging it for once now, so that the biggest changes (e.g. the Comboxes) are into it. |
Fixes #957 and #958
Fix height of the dialog and add spacing between OK/Cancel Button and border
Changed JComboxBox to editable and removed the unnecessary textfields
Added JCombobox for selecting the fields to apply the selected formatter to
Changed position of Delete Button
Removed IndexOutOfBound Exception when no item is selected
Edit// I just see this PR is #999 ;)