Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit tests on Mac and Windows #9992

Closed
wants to merge 4 commits into from
Closed

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 8, 2023

Triggered by #9988

This PR enables running our tests on Windows and Mac OS. In case we add some OS-specific funtionality with tests, they will be executed on the CI, too.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr previously approved these changes Jun 8, 2023
@Siedlerchr
Copy link
Member

Siedlerchr commented Jun 8, 2023

cli tests with string align fails. Seems probably an issue with the whitespace char or so

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Jun 9, 2023
@Siedlerchr
Copy link
Member

Some FileUtil Test fails on Windows and on mac the css file base64 encoding differs. Guess this is okay.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member

Closing this due to inactivity and currenltly not that important

@Siedlerchr Siedlerchr closed this Aug 18, 2023
@koppor koppor added the status: freeze Issues posponed to a (much) later future label Sep 7, 2023
@koppor koppor deleted the add-test-on-windows branch September 26, 2024 06:34
@koppor koppor mentioned this pull request Sep 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes required Pull requests that are not yet complete status: freeze Issues posponed to a (much) later future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants