Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve casing of field names for customize entry types #9993

Merged
merged 13 commits into from
Jun 12, 2023
Merged

Preserve casing of field names for customize entry types #9993

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bea8a8d
Preserve casing of field names for customize entry types
koppor Jun 9, 2023
2a1f9e6
Update CHANGELOG.md
koppor Jun 9, 2023
61b1133
Fix checkstyle
koppor Jun 9, 2023
c9ac197
Add BibEntryTypePrefsAndFileViewModel
koppor Jun 9, 2023
7212aea
Add BibEntry #withChanged
koppor Jun 9, 2023
7a1c751
Replace faux-pas by jool (seems to be more maintained and more easy t…
koppor Jun 9, 2023
f90df22
Use List.of()
koppor Jun 9, 2023
181128d
Insist on SortedSet
koppor Jun 9, 2023
33931fd
Add comment on final list
koppor Jun 9, 2023
61c4f64
Fix test
koppor Jun 9, 2023
c3240f0
Keep casing of known fields
koppor Jun 9, 2023
eb1048c
Merge remote-tracking branch 'upstream/main' into preserve-casing
koppor Jun 11, 2023
0a91315
Fix tests
koppor Jun 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/org/jabref/logic/exporter/BibtexDatabaseWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ void writeCustomizedTypesInAlphabeticalOrder() throws Exception {
database.insertEntry(entry);
bibtexContext.setMode(BibDatabaseMode.BIBTEX);

databaseWriter.savePartOfDatabase(bibtexContext, Arrays.asList(entry, otherEntry));
databaseWriter.savePartOfDatabase(bibtexContext, List.of(entry, otherEntry));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a reason to pass a modifiable list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked the code - no modification of the list inside. I added a JavaDoc comment.


assertEquals(
"@Customizedtype{," + OS.NEWLINE + "}" + OS.NEWLINE + OS.NEWLINE
Expand Down