Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences cleanup C (ExporterFactory & setPreviewStyle) #9998

Merged
merged 11 commits into from
Jun 11, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jun 10, 2023

Follow-up to #9866

In preparation for refactoring the getCustomExporters to the new preferences pattern, I had to move the JournalAbbreviationRepository argument in the constructor to the actual export method. As the journalAbbreviationRepository variable in Globals is overwritten when the preferences are imported or reset, this might have also fixed some hidden bugs. As for now I leave the call to Globals in some places, as fixing that call too would explode this PR.

Commits are mostly self explaining.
Refactoring was made in several iterations, so I had to introduce the JournalAbbreviationRepository in some steps, just to remove it in the next one.

Also made some very small fixes on the fly.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added type: code-quality Issues related to code or architecture decisions preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jun 10, 2023
@calixtus calixtus changed the title Preferences ui cleanup B (ExporterFactory & setPreviewStyle) Preferences ui cleanup C (ExporterFactory & setPreviewStyle) Jun 10, 2023
@calixtus calixtus changed the title Preferences ui cleanup C (ExporterFactory & setPreviewStyle) Preferences cleanup C (ExporterFactory & setPreviewStyle) Jun 10, 2023
@JabRef JabRef deleted a comment from github-actions bot Jun 10, 2023
@calixtus calixtus merged commit 27a22af into main Jun 11, 2023
@calixtus calixtus deleted the custom_exporter_prefs branch June 11, 2023 05:22
@calixtus
Copy link
Member Author

Yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants