-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences cleanup C (ExporterFactory & setPreviewStyle) #9998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
added
type: code-quality
Issues related to code or architecture decisions
preferences
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
labels
Jun 10, 2023
calixtus
changed the title
Preferences ui cleanup B (ExporterFactory & setPreviewStyle)
Preferences ui cleanup C (ExporterFactory & setPreviewStyle)
Jun 10, 2023
calixtus
changed the title
Preferences ui cleanup C (ExporterFactory & setPreviewStyle)
Preferences cleanup C (ExporterFactory & setPreviewStyle)
Jun 10, 2023
src/test/java/org/jabref/logic/openoffice/style/OOBibStyleTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/openoffice/style/OOBibStyleTest.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Jun 10, 2023
Siedlerchr
approved these changes
Jun 10, 2023
koppor
approved these changes
Jun 11, 2023
Yay |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
preferences
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
type: code-quality
Issues related to code or architecture decisions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #9866
In preparation for refactoring the getCustomExporters to the new preferences pattern, I had to move the JournalAbbreviationRepository argument in the constructor to the actual export method. As the journalAbbreviationRepository variable in Globals is overwritten when the preferences are imported or reset, this might have also fixed some hidden bugs. As for now I leave the call to Globals in some places, as fixing that call too would explode this PR.
Commits are mostly self explaining.
Refactoring was made in several iterations, so I had to introduce the JournalAbbreviationRepository in some steps, just to remove it in the next one.
Also made some very small fixes on the fly.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)