Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Entry Editor Preview (#7093) #329

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Overhaul Entry Editor Preview (#7093) #329

merged 1 commit into from
Nov 22, 2020

Conversation

AtrusRiven
Copy link
Contributor

@AtrusRiven AtrusRiven commented Nov 13, 2020

Entry Editor Preview overhauled, added screenshots etc.

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should keep in mind, that in the mid future we try to automate the process of taking screenshots with TestFX. @koppor knows more? But for now it's good.
Thanks.

@AtrusRiven
Copy link
Contributor Author

Why LGTM?

@calixtus
Copy link
Member

LGTM = "Looks good to me"

@AtrusRiven
Copy link
Contributor Author

AtrusRiven commented Nov 19, 2020

Interesting, known to me as "Literally Garbage To Me" ;-)

@Siedlerchr Siedlerchr merged commit f4b1fe4 into JabRef:master Nov 22, 2020
@koppor
Copy link
Member

koppor commented Nov 22, 2020

Automated screenshots: See JabRef/jabref#6089 for code and discussions. Especially JabRef/jabref#6089 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants