-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add settings for note item status #66
Merged
JackGruber
merged 2 commits into
JackGruber:master
from
AndryYosua:remove_status_for_note_item
Dec 24, 2023
Merged
add settings for note item status #66
JackGruber
merged 2 commits into
JackGruber:master
from
AndryYosua:remove_status_for_note_item
Dec 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please create tests for the PR |
### Steps - create a note and todo note - create note-overview ``` <!-- note-overview-plugin search: ... fields: status, title status: todo: open: "☐" done: "🗹" overdue: "⚠" --> ``` ### Actual result note status has same status as todo open status | status | title | | ------ | ------------------------------------------------------- | | ⚠ | [todo overdue](:/722c80cb665549fb94472d4802cfbdc5) | | 🗹 | [todo completed](:/6adfa0f5c5ab4642bc696db08a212baf) | | ☐ | [todo with duedate](:/27de5a7fa4424ad993c6ee251ee88812) | | ☐ | [todo open](:/01bca8a69a9341cabcba59531c0cad8e) | | ☐ | [note 1](:/1809922cc3fa49c1bf8f045cbf6f8e55) | ### Expected result as note do not have status (`overdue`, `open` or `done`), note status should be empty. | status | title | | ------ | ------------------------------------------------------- | | ⚠ | [todo overdue](:/722c80cb665549fb94472d4802cfbdc5) | | 🗹 | [todo completed](:/6adfa0f5c5ab4642bc696db08a212baf) | | ☐ | [todo with duedate](:/27de5a7fa4424ad993c6ee251ee88812) | | ☐ | [todo open](:/01bca8a69a9341cabcba59531c0cad8e) | | | [note 1](:/1809922cc3fa49c1bf8f045cbf6f8e55) |
AndryYosua
force-pushed
the
remove_status_for_note_item
branch
from
December 15, 2023 03:31
8665694
to
74612fe
Compare
done |
AndryYosua
changed the title
remove status for note item
add settings for note item status
Dec 15, 2023
Please make the following adjustments:
I think then I can merge the PR |
done
and done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While todo item has status
overdue
,open
ordone
, note item do not has one.This PR add settings for note item status
Steps
Actual result
note status and todo status has same status
Expected result
as note do not have status (
overdue
,open
ordone
), note status should be empty.Other Result