Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tnr_ using same cutoff as confusionMatrix_ #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

labrax
Copy link

@labrax labrax commented Feb 11, 2021

Hi Tyler,

Hope you are doing well. Thanks for this great package.

On https://github.com/JackStat/ModelMetrics/blob/master/src/confusionMatrix_.cpp:

  • confusionMatrix_ considers predictions as negative if the value is <= 0
  • tnr_ considers predictions as negative if the value is < 0.

I suggest to standardise it using confusionMatrix_, as in the attached patch.

I am not fully aware, but I strongly suggest checking the functions mcc_ and kappa_ as they might have a different result due to the different way it is calculated.

Best wishes,
Victor

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 56.429% when pulling 8230b81 on labrax:master into d3cbb5f on JackStat:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants