tnr_ using same cutoff as confusionMatrix_ #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tyler,
Hope you are doing well. Thanks for this great package.
On https://github.com/JackStat/ModelMetrics/blob/master/src/confusionMatrix_.cpp:
confusionMatrix_
considers predictions as negative if the value is <= 0tnr_
considers predictions as negative if the value is < 0.I suggest to standardise it using
confusionMatrix_
, as in the attached patch.I am not fully aware, but I strongly suggest checking the functions
mcc_
andkappa_
as they might have a different result due to the different way it is calculated.Best wishes,
Victor