Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jkl 161 add read me #149

Merged
merged 12 commits into from
Dec 5, 2022
Merged

Jkl 161 add read me #149

merged 12 commits into from
Dec 5, 2022

Conversation

BiPhan4
Copy link
Contributor

@BiPhan4 BiPhan4 commented Dec 2, 2022

Please review for accuracy.

@TheMarstonConnell
Copy link
Member

@BiPhan4 still need a review on this or did erin look over it?

@BiPhan4
Copy link
Contributor Author

BiPhan4 commented Dec 2, 2022

@TheMarstonConnell Erin gave me some feed back on it but never clicked approve. I can wait for him to approve--he's who will be relying on it the most.

Copy link
Member

@dahn510 dahn510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BiPhan4
Copy link
Contributor Author

BiPhan4 commented Dec 5, 2022

@karnthis Hey Erin - could you click approve on this if it looks good to you? Cheers

@karnthis
Copy link
Member

karnthis commented Dec 5, 2022

PR still has mixed casing styles. I don't know the implications of this on Golang, but this would be highly problematic for Javascript.

@BiPhan4
Copy link
Contributor Author

BiPhan4 commented Dec 5, 2022

@karnthis Ah you've pointed out an inconsistency with protocol buffers and golang standard. The .proto definitions are camel case but the generated class files--.pb.go--class files are using pascal casing.

The CLI wraps the tx.pb.go class file to use functions that take camelCase arguments, but it does not wrap query.pb.go--PascalCasing. I mistakenly followed the CLI when writing this readMe.

I've changed the readMe to reflect the types as they are defined in their .proto files, the single source of truth across all language implementations. Your APIs compile directly from the .proto files so you're good to go.

@TheMarstonConnell I merged most recent 1.2.0 into this PR just now and pushed my edit to the readMe. Please merge this PR into 1.2.0 if it all checks out.

Thank you.

Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 140/141 are still using inconsistent casing with the rest of the document. Please either update or notate the exceptions to the rule.

|hashparent | String | MerklePath("s")

|hashchild | String | Hex[ hash("home") ]

@BiPhan4 BiPhan4 requested a review from karnthis December 5, 2022 21:42
@BiPhan4
Copy link
Contributor Author

BiPhan4 commented Dec 5, 2022

@karnthis Fixed it. Thanks for catching that.

@TheMarstonConnell TheMarstonConnell merged commit a2b0b64 into 1.2.0 Dec 5, 2022
@TheMarstonConnell TheMarstonConnell deleted the JKL-161-add-read-me branch December 13, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants