Jkl 198 msg buy storage bug fix & simulation implementation #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…75-add-storage-module-sim
…rage operation for simulation
|
I'm not the appropriate person to review this PR as I've not been working on the new payment system. I defer to Justin and Erin here. |
|
No proto changes? |
Nope |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
If nuggie says ok I'm good. This will require a FE change not a proto change. LGTM |
dahn510
changed the title
…bs/canine-chain into JKL-198-msg-buy-storage-bug-fix
|
the bug fix is good to go, I'll wait till we sort out the fail simulation test before approving this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug that prevents user from buying storage.
Duration value of the MsgBuyStorage test cases are changed to time.Duration format.