fix upgrade storage plan end date calculation and add upgrade-storage cli cmd #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahn510
changed the title
|
Missing cli cmd for upgrade-storage cmd has been added. |
good catch, definitely my bad for forgetting that cli cmd |
| @@ -29,7 +29,7 @@ func GetTxCmd() *cobra.Command { | |||
| cmd.AddCommand(CmdCancelContract()) | |||
| cmd.AddCommand(CmdBuyStorage()) | |||
| cmd.AddCommand(CmdClaimStray()) | |||
| // this line is used by starport scaffolding # 1 | |||
| cmd.AddCommand(CmdUpgradeStorage()) | |||
There was a problem hiding this comment.
Good catch, can't believe I left that out
TheMarstonConnell
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a miscalculation in storage plan end date. canine-chain/msg_server_upgrade_storage.go at a39271478a28f936e1c787a736532c89ffe31671 · JackalLabs/canine-chain
Month time of type time.Time multiplied with upgrade duration of type time.Duration large enough (like a month) will create integer overflow and result in end date being earlier than current time.
The fix removes timeMonth * timeDuration and End date is calculated as ctx.BlockTime().Add(duration).