Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: P2P Attestation #335

Merged
merged 41 commits into from
Jun 21, 2023
Merged

Feat: P2P Attestation #335

merged 41 commits into from
Jun 21, 2023

Conversation

TheMarstonConnell
Copy link
Member

Storage proofs can be handled completely off-chain by creating an attestation system.

@TheMarstonConnell TheMarstonConnell self-assigned this May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #335 (cb721d2) into master (8c06429) will decrease coverage by 0.32%.
The diff coverage is 41.03%.

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   47.62%   47.30%   -0.32%     
==========================================
  Files         231      237       +6     
  Lines        8139     8644     +505     
==========================================
+ Hits         3876     4089     +213     
- Misses       4016     4300     +284     
- Partials      247      255       +8     
Impacted Files Coverage Δ
x/storage/keeper/grpc_query_providers.go 17.39% <0.00%> (-5.47%) ⬇️
x/storage/keeper/migrations.go 0.00% <0.00%> (ø)
x/storage/types/key_providers.go 25.00% <0.00%> (-75.00%) ⬇️
x/storage/types/keys.go 0.00% <ø> (ø)
x/storage/types/message_attest.go 0.00% <0.00%> (ø)
x/storage/types/message_shutdown_miner.go 0.00% <0.00%> (ø)
x/storage/types/params.go 12.14% <7.14%> (-2.15%) ⬇️
x/storage/keeper/collateral.go 17.64% <17.64%> (ø)
x/storage/keeper/grpc_query_attestation.go 22.85% <22.85%> (ø)
x/storage/keeper/msg_server_init_provider.go 47.61% <29.78%> (-52.39%) ⬇️
... and 7 more

@TheMarstonConnell TheMarstonConnell marked this pull request as ready for review June 21, 2023 07:06
Copy link
Member

@dahn510 dahn510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Thank you!

x/storage/keeper/msg_server_attest.go Show resolved Hide resolved
x/storage/keeper/msg_server_attest.go Outdated Show resolved Hide resolved
x/storage/keeper/msg_server_attest.go Show resolved Hide resolved
@TheMarstonConnell TheMarstonConnell merged commit 74b4c97 into master Jun 21, 2023
@TheMarstonConnell TheMarstonConnell deleted the attestation-impl branch June 21, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants