Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL: Cleaning Proto Files #378

Merged
merged 14 commits into from
Nov 14, 2023
Merged

QoL: Cleaning Proto Files #378

merged 14 commits into from
Nov 14, 2023

Conversation

TheMarstonConnell
Copy link
Member

Currently the protos are a mess. Some generated with Ignite before ignite handled data types that weren't strings, some generated by real humans who didn't have a "proto-standardization manual" in front of them.

From here on out we are adopting a protobuf styling standard following that of the Cosmos-SDK. Types will be clearly defined in Camel Case to match golang types, but fields in those types will be formatted with snake case to make them distinguishable from each other at a glance.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (3ef4ccb) 43.89% compared to head (97430e9) 43.98%.
Report is 1 commits behind head on master.

Files Patch % Lines
x/storage/keeper/grpc_query_active_deals.go 0.00% 27 Missing ⚠️
x/filetree/types/message_make_rootv2.go 0.00% 8 Missing ⚠️
x/storage/types/message_set_miner_totalspace.go 12.50% 7 Missing ⚠️
x/filetree/types/message_postkey.go 37.50% 5 Missing ⚠️
x/rns/client/cli/query_bids.go 0.00% 5 Missing ⚠️
x/rns/client/cli/query_names.go 0.00% 5 Missing ⚠️
x/rns/client/cli/tx_register.go 0.00% 5 Missing ⚠️
x/storage/keeper/grpc_query_freespace.go 0.00% 5 Missing ⚠️
x/rns/client/cli/query_forsale.go 0.00% 4 Missing ⚠️
x/rns/keeper/grpc_query_forsale.go 0.00% 4 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   43.89%   43.98%   +0.09%     
==========================================
  Files         233      231       -2     
  Lines        8742     8642     -100     
==========================================
- Hits         3837     3801      -36     
+ Misses       4664     4600      -64     
  Partials      241      241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheMarstonConnell TheMarstonConnell marked this pull request as ready for review November 9, 2023 04:21
@TheMarstonConnell TheMarstonConnell self-assigned this Nov 9, 2023
Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed a number of small inconsistencies, not sure if they are left for compatibility.

proto/canine_chain/filetree/tx.proto Outdated Show resolved Hide resolved
proto/canine_chain/filetree/tx.proto Outdated Show resolved Hide resolved
proto/canine_chain/rns/query.proto Outdated Show resolved Hide resolved
proto/canine_chain/rns/query.proto Show resolved Hide resolved
proto/canine_chain/rns/tx.proto Outdated Show resolved Hide resolved
proto/canine_chain/storage/query.proto Outdated Show resolved Hide resolved
proto/canine_chain/storage/query.proto Outdated Show resolved Hide resolved
proto/canine_chain/storage/query.proto Outdated Show resolved Hide resolved
proto/canine_chain/storage/tx.proto Outdated Show resolved Hide resolved
proto/canine_chain/storage/tx.proto Outdated Show resolved Hide resolved
Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, down to the last few items!

proto/canine_chain/filetree/query.proto Outdated Show resolved Hide resolved
proto/canine_chain/filetree/tx.proto Outdated Show resolved Hide resolved
proto/canine_chain/rns/query.proto Outdated Show resolved Hide resolved
proto/canine_chain/rns/query.proto Outdated Show resolved Hide resolved
Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. there are comments that we can clean up over time

@TheMarstonConnell TheMarstonConnell merged commit 6a054d4 into master Nov 14, 2023
8 of 11 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/proto-cleaning branch November 14, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants