Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing upgrade proof interval #459

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

TheMarstonConnell
Copy link
Member

@TheMarstonConnell TheMarstonConnell commented Jun 30, 2024

ideally would be the last piece of the pie for v4

@TheMarstonConnell TheMarstonConnell self-assigned this Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 4.65116% with 41 lines in your changes missing coverage. Please review.

Project coverage is 42.25%. Comparing base (7834ddb) to head (bebac41).

Files Patch % Lines
app/upgrades/v4/upgrades.go 6.66% 28 Missing ⚠️
x/storage/client/cli/query_address.go 0.00% 12 Missing ⚠️
x/storage/client/cli/query.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   42.38%   42.25%   -0.14%     
==========================================
  Files         401      402       +1     
  Lines       13138    13177      +39     
==========================================
- Hits         5569     5568       -1     
- Misses       7183     7223      +40     
  Partials      386      386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheMarstonConnell TheMarstonConnell marked this pull request as ready for review July 2, 2024 16:12
@TheMarstonConnell TheMarstonConnell merged commit 9ba9d47 into master Jul 2, 2024
8 of 11 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/v4-smodule-update branch July 21, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant