Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recovery #468

Merged
merged 15 commits into from
Oct 3, 2024
Merged

recovery #468

merged 15 commits into from
Oct 3, 2024

Conversation

TheMarstonConnell
Copy link
Member

Recovery of merkles in upgrade

"github.com/jackalLabs/canine-chain/v4/x/storage/types"
)

const MerkleSize = `075fe59e0539e2250ab61becec3a9b3568daf1564f8624ca45b767d176af4ca8e42dde52d00cd8432f779ac1f55bf2fa02ac032b3da318ccab8af2c9dc722de4,25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dahn510 this is what the format needs to look like if possible

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 24.74227% with 73 lines in your changes missing coverage. Please review.

Project coverage is 42.45%. Comparing base (40d9585) to head (afd2be0).

Files Patch % Lines
app/upgrades/v410/upgrades.go 46.00% 23 Missing and 4 partials ⚠️
x/storage/client/cli/query.go 0.00% 24 Missing ⚠️
x/storage/client/cli/query_active_deals.go 0.00% 20 Missing ⚠️
x/storage/keeper/grpc_query_active_deals.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
- Coverage   42.49%   42.45%   -0.04%     
==========================================
  Files         404      405       +1     
  Lines       13252    13329      +77     
==========================================
+ Hits         5631     5659      +28     
- Misses       7222     7269      +47     
- Partials      399      401       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheMarstonConnell TheMarstonConnell marked this pull request as ready for review October 3, 2024 16:06
Copy link
Member

@dahn510 dahn510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheMarstonConnell TheMarstonConnell merged commit 8b03d85 into master Oct 3, 2024
6 of 9 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/recovery branch October 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants