Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add localization editor and ide extension #32

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

NilsJacobsen
Copy link
Contributor

Hi together, let me know what I need to change in order to merge this

Added a localization editor & ide extension for better i18n handling

  • Faster message extraction
  • Continuous i18n process improvements
  • Improved translation status

Editor -> Fink Translation Editor (Open Editor)

image

IDE Extension

image

What I added

  • Added project.inlang/settings.json file to configure the inlang project.
  • repo id file was generated by the SDK
  • Added the extension to the vscode recommendations, so every contributor con benefit

All opt-in

  • I didn't change you setup, everybody can use what they want (opt-in)
  • It's only a config

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: 73dca49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JacobLinCool
Copy link
Owner

Wow! I had never heard of InLang before, but it seems like a cool toolkit for i18n!

I'm willing to merge this PR, but I am curious about two things:

  1. Why choose InLang instead of other i18n collaboration tools like Crowdin?
  2. Currently, I am using i18n-ally as my VSCode extension for i18n personally. Sometimes, I just rely on its auto-translation button. 😃 Will the new extension conflict with i18n-ally?

Also, I noticed that you have included a project.inlang/project_id file, and the Fink Translation Editor link you provided is pointing to your fork. I am not sure if this will cause any problems?

@JacobLinCool JacobLinCool self-requested a review January 25, 2024 21:11
@NilsJacobsen
Copy link
Contributor Author

Hi @JacobLinCool,

Why choose InLang instead of other i18n collaboration tools like Crowdin?

Crowdin stores translations on their server -> syncing must be established. inlang is lazy cloning the repo in the browser and let you work directly on the files with a view that is made for translators. Other tools like the ide extension or the CLI are working with the same approach. One source of truth, which leads to a single little settings file to configure.

Currently, I am using i18n-ally as my VSCode extension for i18n personally. Sometimes, I just rely on its auto-translation button. 😃 Will the new extension conflict with i18n-ally?

You can continue using i18n ally. No worries. It's all opt-in. As far as I interpret the activity in their repo, I think it's not well maintained anymore, though. I recommend using the CLI in your build/test step to lint missing translations and/or machine translate -> Guide. But as I said, it's all opt-in.

@NilsJacobsen
Copy link
Contributor Author

Also, I noticed that you have included a project.inlang/project_id file, and the Fink Translation Editor link you provided is pointing to your fork. I am not sure if this will cause any problems?

The id is generated by the SDK and will also work when merging to main, so no worries.

project.inlang/project_id Show resolved Hide resolved
@JacobLinCool
Copy link
Owner

Great! I'll give it a try. Thank you for the contribution.

@JacobLinCool JacobLinCool merged commit 0abfbdc into JacobLinCool:main Jan 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants