Assignment 2 - Solution #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Nov 23, 2020
| @@ -68,6 +72,10 @@ class CScene | |||
| bool intersect(Ray& ray) const | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
There was a problem hiding this comment.
This function is implemented wrong. You return the first found intersection, instead of checking all possible intersections.
| @@ -87,7 +99,8 @@ class CScene | |||
| Vec3f RayTrace(Ray& ray) const | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
| return Vec3f(); | |||
| if(intersect(ray)) { return ray.hit->getShader()->shade(ray); } | |||
There was a problem hiding this comment.
getShader() method throws an error because you do not fill ray.hit in your interestion algorithms.
| for(auto light : m_scene.getLights()) { | ||
| for(int i = 0; i < n; i ++) { | ||
| if(!light->illuminate(shade)) | ||
| if(m_scene.occluded(shade)) |
There was a problem hiding this comment.
Somehow the shadows are not rendered at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.