Assignment 3 Kvonseggern #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added rendering time to Part 1, changed the lines with the filepath to torus
ereator
reviewed
Dec 4, 2020
| @@ -52,8 +52,8 @@ If everything so far was implemented correctly, the Scene bounds will be: [-6, 0 | |||
| For more information please read the chapter 7.2 in the [thesis of Dr. Ingo Wald](http://www.sci.utah.edu/~wald/PhD/wald_phd.pdf). | |||
| 6. Implement the method ```std::shared_ptr<CBSPNode> build(const CBoundingBox& box, const std::vector<ptr_prim_t>& vpPrims, size_t depth)``` of the class ```CBSPTree```. Use the ideas presented at the lecture. As soon as you have reached a maximum depth (_e.g._ 20), or you have less then a minimum number of primitives (_e.g._ 3 or 4), stop subdividing and generate a leaf node. Otherweise, split your bounding box in the middle (in the maximum dimension), sort your current primitives into two vector left and right, and recursively call BuildTree with the respective bounding boxes and vector for left and right. Start subdivision with a list of all primitives, the total scene bounds, and an initial recursion depth of 0.<br> | |||
| 9. Render the scene and write the time needed for 1 frame T2 and speedup = T0 / T2 below:<br> | |||
| **T2:** .......<br> | |||
| **Speedup:** ....... | |||
| **T2:** 3284 ms<br> | |||
There was a problem hiding this comment.
Strange, the speedup here should be much higher, like 190 times as reported for task 4....
| @@ -81,7 +93,7 @@ class CBSPTree | |||
| CBoundingBox& lBox = splitBoxes.first; | |||
There was a problem hiding this comment.
It looks like the last problem was not done: splitDim and splitVal are unchanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.