eyden-tracer-05 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Dec 25, 2020
| return Vec2f::all(0.5f); | ||
| // n - number of samples | ||
| int n = getNumSamples(); | ||
| float i = ((s % n) + 0.5) / float(sqrt(n)); |
There was a problem hiding this comment.
here you need to use sort(n) instead of n
| float ei = Random::U<float>(); | ||
| float ej = Random::U<float>(); | ||
|
|
||
| float i = ((s % n) + ei) / float(sqrt(n)); |
There was a problem hiding this comment.
here you need to use sqrt(n) instead of n
| @@ -39,7 +39,31 @@ class CLightArea : public CLightOmni | |||
| virtual std::optional<Vec3f> illuminate(Ray& ray) override | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
| return std::nullopt; | |||
| Vec2f sample(0, 0); | |||
| size_t k = 0; | |||
There was a problem hiding this comment.
it will be all the time 0
You need to make it static or member variable to save the state over the different calls of the function
| @@ -27,17 +27,55 @@ class CShaderGlossy : public CShaderPhong { | |||
| virtual Vec3f shade(const Ray& ray) const override { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.