eyden-tracer-06 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Dec 29, 2020
| } | ||
|
|
||
| float getAngle(void) const { | ||
| (360 / Pif * atan(1 / m_focus)); |
| private: | ||
| Vec3f m_target; ///< Camera target point in WCS | ||
| } | ||
| Vec3f m_pos; |
There was a problem hiding this comment.
position must not be here
setPosition() and setTarget() both affect the direction of the camera
| // sin(66.5 deg) = 0.917 | ||
| // cos(66.6 deg) = 0.399 | ||
| Mat earthTransform = transform.rotate(Vec3f(0.399f, 0.917, 0), 360.0f / nFrames).get(); | ||
| Mat moonTransform = transform.rotate(Vec3f(0, 1, 0), 13.2f / nFrames).get(); |
There was a problem hiding this comment.
what is 13.2f ? how this number is calculated?
| //Mat rotationAroundTheSun = Mat::eye(4, 4, CV_32FC1); | ||
| Vec3f ePivot = earth.getPivot(); | ||
| std :: cout << "Earth pivot: " << ePivot << std :: endl; | ||
| Mat rotationAroundTheSun = transform.translate(ePivot).rotate(Vec3f(0, 1, 0), 1.0f / nFrames).translate(-ePivot).get(); |
There was a problem hiding this comment.
What is 1.0f / nFrames? How this number was achieved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.