Skip to content

Commit

Permalink
reinserted req6 as mentioned in issue #327
Browse files Browse the repository at this point in the history
  • Loading branch information
niazim3 committed Jun 29, 2017
1 parent d6ca3b0 commit ff7e1dd
Showing 1 changed file with 19 additions and 3 deletions.
22 changes: 19 additions & 3 deletions code/Example/Drasil/GlassBR/Body.hs
Original file line number Diff line number Diff line change
Expand Up @@ -489,10 +489,10 @@ s7 = reqF [s7_1, s7_2]

s7_1 = SRS.funcReq (s7_1_list) []

s7_1_req6 :: ItemType
s7_1_req6 :: [Contents] -- :: ItemType
s7_1_req1, s7_1_req2, s7_1_req3, s7_1_req4, s7_1_req5 :: Sentence

s7_1_list = [enumSimple 1 (getAcc requirement) (s7_1_listOfReqs)] ++ [s7_1_req1Table]
s7_1_list = [enumSimple 1 (getAcc requirement) (s7_1_listOfReqs)] ++ s7_1_req6 ++ [s7_1_req1Table]

s7_1_listOfReqs :: [Sentence]
s7_1_listOfReqs = [s7_1_req1, s7_1_req2, s7_1_req3, s7_1_req4, s7_1_req5]
Expand Down Expand Up @@ -550,6 +550,22 @@ s7_1_req5 = S "If" +:+ (getS is_safe1) `sAnd` (getS is_safe2) +:+
S "If the" +:+ phrase condition +:+ S "is false, then" +:+ phrase output_ +:+
S "the message" +:+ Quote (notSafe ^. defn)

s7_1_req6 = [(Enumeration $ Simple $ [(acroR 6, Nested (titleize output_ +:+
S "the following" +: plural quantity)
(Bullet $
[Flat $ (at_start prob_br) +:+ sParen (getS prob_br) +:+ sParen (makeRef (gbSymbMapT probOfBr))] ++
[Flat $ (titleize lResistance) +:+ sParen (short lResistance) +:+ sParen (makeRef (gbSymbMapT calOfCap))] ++
[Flat $ (at_start demand) +:+ sParen (getS demand) +:+ sParen (makeRef (gbSymbMapT calOfDe))] ++
[Flat $ (at_start act_thick) +:+ sParen (getS act_thick) +:+ sParen (makeRef (gbSymbMapD hFromt))] ++
[Flat $ (titleize loadDF) +:+ sParen (getS loadDF) +:+ sParen (makeRef (gbSymbMapD loadDF))] ++
[Flat $ (at_start strDisFac) +:+ sParen (getS strDisFac) +:+ sParen (makeRef (gbSymbMapD strDisFac))] ++
[Flat $ (titleize nonFL) +:+ sParen (getS nonFL) +:+ sParen (makeRef (gbSymbMapD nonFL))] ++
[Flat $ (titleize gTF) +:+ sParen (getS gTF) +:+ sParen (makeRef (gbSymbMapD glaTyFac))] ++
map (\c -> Flat $ (at_start c) +:+ sParen (getS c) +:+ sParen (makeRef (gbSymbMapD c))) [dimLL, tolPre, tolStrDisFac] ++
[Flat $ (titleize aspectR) +:+ sParen (short aspectR {-getS aspectR -}) {-+:+ E ((C aspectR) := (C plate_len):/(C plate_width))-}]
))])]

{-
--ItemType
s7_1_req6 = (Nested (titleize output_ +:+
S "the following" +: plural quantity)
Expand All @@ -574,7 +590,7 @@ s7_1_req6 = (Nested (titleize output_ +:+
[]
)
-}

-}
--FIXME:The implementation above is quite repetitive in nature.

{--Nonfunctional Requirements--}
Expand Down

3 comments on commit ff7e1dd

@JacquesCarette
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there has to be a better way to separate the 'knowledge' from the rendering of s7_1_req6...

@niazim3
Copy link
Collaborator Author

@niazim3 niazim3 commented on ff7e1dd Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, s7_1_req6 is defined as follows:
image.
Issue #327 is still open as I'm working on impelementing the section in a better manner.

@JacquesCarette
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the "problem" with me commenting on intermediate check-ins is that you may well know that it is a 'waypoint' to where you are going, but I don't.

Continue to work exactly as you have. Many small check-ins is the right way to do things. On this, I'll wait until you close #327 before redoing a thorough review.

Please sign in to comment.