Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWHS: Difference b/w Stable and Manual: Add definitions for tau_P^S and tau_P^L #1070

Closed
smiths opened this issue Nov 28, 2018 · 3 comments
Closed

SWHS: Difference b/w Stable and Manual: Add definitions for tau_P^S and tau_P^L #1070

smiths opened this issue Nov 28, 2018 · 3 comments
Assignees
@danscime

Comments

@smiths
Copy link
Collaborator

smiths commented Nov 28, 2018

Issue #1069 highlighted that tau_P^S and tau_P^L need to be added as data definitions. This was done in the manual version at:

smiths/swhs@6bf8ec0

These changes need to be propagated to stable (Drasil)
@danscime danscime mentioned this issue May 1, 2019
Closed
@danscime
Copy link
Collaborator

danscime commented May 2, 2019

Beginning to add these via e6cbbf9

@danscime
Copy link
Collaborator

danscime commented May 2, 2019

Added tau_P^S via b6cea70

@danscime danscime self-assigned this May 2, 2019
@danscime danscime mentioned this issue May 2, 2019
Closed
@danscime
Copy link
Collaborator

danscime commented May 7, 2019

Added tau_P^L via df8733d.
Original PR #1253.
These data definitions ended up being added in #1257.
I believe this issue can be closed.

@smiths smiths mentioned this issue Jun 3, 2019
Closed
@smiths smiths mentioned this issue Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danscime danscime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swhs datadefs JacquesCarette/Drasil
3 participants
@smiths @JacquesCarette @danscime