Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWHS: Difference b/w Stable and Manual: Match output of IM2 #1069

Closed
smiths opened this issue Nov 28, 2018 · 0 comments · Fixed by #1805
Closed

SWHS: Difference b/w Stable and Manual: Match output of IM2 #1069

smiths opened this issue Nov 28, 2018 · 0 comments · Fixed by #1805
Assignees

Comments

@smiths
Copy link
Collaborator

smiths commented Nov 28, 2018

Issue #523 has far too much going on to keep track of all of the details. This issue (and several others) highlights one specific difference between Stable and Manual.

  • Missing information for the output of IM2 (non-trivial)
    Stable:
    image
    Manual:
    image

IM2 has been updated in the stable (Drasil) version:

im2

Unfortunately the updates still don't entirely match the manual versions. The following changes still need to be made:

  • The Equation doesn't match the manual version; it should have 3 cases (not 4)
  • The note should contain the following bulleted list (ideally displayed as a bulleted list for ease of reading/verifying):
    • T_W is defined by (IM: eBalanceOnWtr).
    • The input constraint Tinit ≤ T_P^melt comes from (A: PCM-Initially-Solid).
    • The temperature remains constant at TmeltP, even with the heating (or cool-ing), until the phase change has occurred for all of the material; that is as long as 0 < ϕ < 1. ϕ (from DD: melt_frac ) is determined as part of the heat energy in the PCM, as given in (IM: heatEInPCM).
    • tau_P^S is calculated in DD? (needs to be added)
    • tau_P^L is calculated in DD? (needs to be added)
@smiths smiths changed the title SWHS: Difference b/w Stable and Manual: Add definitions for tau_w and eta SWHS: Difference b/w Stable and Manual: Match output of IM2 Nov 28, 2018
samm82 added a commit that referenced this issue Jun 7, 2019
samm82 added a commit that referenced this issue Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants