-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finding all calls to dqd, dqdNoUnit, dqd', dqdWr and dqdQd #2704
Comments
dqdNoUnitin Data.Drasil.Quantitiies.Physics:
in Data.Drasil.Quatities.Math:
in Data.Drasil.Quantities.SolidMechanics:
in Drasil.GlassBR.Unitals:
Drasil.PDController.Unitals:
dqd’in Data.Drasil.Quatities.Math:
in Drasil.SSP.Unitals:
in Drasil.Projectile.Unitals:
in Drasil.SWHS.Unitals:
in Language.Drasil.Chunk.Constrained: in Language.Drasil.Chunk.Unital:
dqdQdIn Database.Drasil.ChunkDB.GetChunk:
in Drasil.GlassBR.IMods:
dqdin Drasil.GlassBR.Unitals:
in Drasil.Projectile.Unitals:
in Drasil.PDController.Unitals:
in Language.Drasil.Chunk.Constrained:
in Language.Drasil.Chunk.Unital:
dqdWRin Drasil.GlassBR.IMods:
in Drasil.SSP.Requirements:
in Drasil.SSP.Unitals:
in Drasil.GamePhysics.Unitals:
in Drasil.NoPCM.Body:
in Drasil.SWHS.Unitals:
in Language.Drasil.Chunk.Constrained:
All defined in Language.Drasil.Chunk.DefinedQuantity |
This change should be done "incrementally", in the sense that the ones that are very easy to change from |
for changing
to
There's an error of " • Couldn't match expected type ‘DefinedQuantityDict’ with actual type ‘Language.Drasil.Chunk.Unital.UnitalChunk’ " I see that
is the right move to edit ConstrConcept or we don't want to touch that? |
We're going to want to hold off on that, because it is going to be tricky. So, for now, leave it as What we'll need to do will be to add a |
okay, then should i go ahead and replace |
Yes - although it will not be a fully straightforward swap, because of |
please for I see dqdWr phrases should be in this structure: And lastly for scenario's like this:
After switching out the constructors would you like the type to be changed to |
For For things like For |
for aspect ratio in GlassBr/ Unitals it says it has no unit & uses the constructor
I see it has been done before with radian here in Data.Drasil.Si_Units:
Should this be edited so |
Also these 3 below are the only other instances that use unital chunk constructors but don't have units themselves.
found in Drasil.PDController.Unitals |
@JacquesCarette is the expert on this topic. However, the units of m/m are a bit misleading. The units could be ft/ft, or 1000 m/1 km. The result is dimensionless. The unit is 1. However, saying the units are m/m does capture some information. If it was a dimensionless temperature, the units would be K/K (Kelvin over Kelvin). In both cases the units are 1, but keeping the ratio gives us some information that might be useful at some point. |
Right - units cancel. So metre/metre is understood as 'unitless', because it's really So while |
Which brings us to a trick part: there is a difference between dimensionless and has no units !!! I mean, in 'physics', not merely in Drasil. A dimensionless quantity can arise as a computation involving quantities-with-units (when they all cancel); once you have units, you always have units. So we ought to have a |
An update on the status of the remaining Projectile ExampleUsing If So...
If Not...should another helper be defined similarly to SSP/SWHS ExamplesAll calls to Chunk/ConstrainedThe function is used in Chunk/EqMost calls to |
For more context, the origin of this issue is related to #2677 |
As we discussed in #3066, the next step is to create issues related to specific examples that seem off. The examples might be providing dummy values or use a Maybe. |
For
|
I'm not quite sure what the ultimate goal of this ticket is (nor why/what the problem is). @samm82, seeing as you assigned yourself, do you think you can update the original post? Or add an extra explanation somewhere? |
I believe this issue was originally to remove the use of |
Hasn't the original purpose of this issue been satisfied? The issue's title says to find all calls to dqd, dqdNoUnit, dqd', dqdWr and dqdQd. I see a list of calls included above. I wonder if we should close this issue, but create new issues related to the needed improvements that have been identified. If the issue is a discussion of the redesign of how we build chunks, then we should link it to the other issues related to this task. |
It has been, yes. If we could do that, I think it would be best. @samm82 do you know what tickets could be spun off? |
Searching Drasil for all calls to dqd, dqdNoUnit, dqd', dqdWr and dqdQd
The text was updated successfully, but these errors were encountered: