SSP Inputs #1221
Merged
SSP Inputs #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiths
requested changes
Apr 23, 2019
There was a problem hiding this comment.
@bmaclach, the changes to stable look fine to me, but I don't like the implication that we are losing information. I agree that Drasil cannot currently support all of the constraints that we have in the manual version, but I don't like the idea of leaving sections blank. This implies that we are going to lose information. Can you include the constraint information in the notes field, so that we don't lose it. As Drasil matures we can move it out of notes into the proper representation.
|
@smiths I added all of the constraints to the Notes field of the critical slip surface identification IM. I also added some FIXMEs to remind us to replace that with actual constraints once that is possible. |
smiths
approved these changes
Apr 24, 2019
|
Sounds good. |
JacquesCarette
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SSP inputs to match manual. The constraints for many of the inputs are left blank for now because we can't express them with Drasil's current Constraint possibilities (see #1220).