Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Precision Capabilities #1278

Merged
merged 30 commits into from
May 10, 2019
Merged

Adding Precision Capabilities #1278

merged 30 commits into from
May 10, 2019

Conversation

samm82
Copy link
Collaborator

@samm82 samm82 commented May 7, 2019

Added the ability to specify a precision for uncertainties, which will close #1258.

@samm82 samm82 requested a review from JacquesCarette May 7, 2019 14:49
@samm82

This comment has been minimized.

@JacquesCarette

This comment has been minimized.

@samm82 samm82 closed this May 7, 2019
@samm82
Copy link
Collaborator Author

samm82 commented May 7, 2019

@JacquesCarette I've made the fix - there are now two accessors, uncVal and uncPrec to get the fields of the Uncertainty returned by the Lens from HasUncertainty.

@samm82 samm82 reopened this May 7, 2019
@samm82
Copy link
Collaborator Author

samm82 commented May 9, 2019

Closing until I improve the helper functions

@samm82 samm82 closed this May 9, 2019
@samm82
Copy link
Collaborator Author

samm82 commented May 10, 2019

I think I've got it now

@samm82 samm82 reopened this May 10, 2019
@samm82 samm82 removed the CI: HLint label May 10, 2019
@JacquesCarette JacquesCarette merged commit 7e962a0 into master May 10, 2019
@JacquesCarette JacquesCarette deleted the precision branch May 10, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying Precision
4 participants