Website update #3059
Website update #3059
Conversation
|
@peter-michalski, what is the best way to review these changes. I've clicked around through the code, but it would be nice to see the web-page itself, rather than the code that generates it. Is there a way to generate the web-page from this branch to look at it? |
@smiths, you will need to clone my repo, go into the branch and |
|
Thanks @peter-michalski. Building the webpage on from your fork was very helpful for reviewing the finished product. By the way, why are you using a fork instead of a branch? Is it something to do with building the webpage? The new webpage looks good to me. I like the reorganization and the links to more detailed information. I didn't do a deep dive, but one thing I couldn't find was instructions to build the website, like the instructions you gave me. 😄 I think we should include these for future website maintainers. |
There was a problem hiding this comment.
I approve of the new webpage, but I'll leave it to @JacquesCarette to determine if the webpage is ready to be merged.
No, just out of habit I work in forked repos when I am not an owner or frequent developer. I started working with Drasil in the same mindset, but now that you mention it, it might be a good idea to go ahead and branch the main repo when working on future issues. |
|
Yes, we definitely want you to become a "frequent developer" of Drasil! (Review of this incoming) |
There was a problem hiding this comment.
As far as improving the website, this achieves that aim, in a way that's completely consistent with what is already here - thus the approval.
A deeper look at the code reveals all sorts of opportunities for further improvement. But it doesn't make sense to hold up these improvements for that, but make them another round.
|
The new website looks great! 😄 |
Updates for #3039