Standardize Non-Functional Requirement Labels. #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inconsistencies across examples.
- Modified the following examples: dblpend, GlassBR, SWHSNoPCM, PDController, Projectile, SglPend, SSP, SWHS.
Xinlu-Y
requested review from
JacquesCarette,
smiths,
samm82,
bmaclach and
cd155
as code owners
Xinlu-Y
force-pushed
the
NFRConsistency
branch
from
a7d335e
to
ad2ff01
Compare
keep the code clean and avoid unnecessary dependencies.
Xinlu-Y
force-pushed
the
NFRConsistency
branch
from
ad2ff01
to
551a7b8
Compare
smiths
reviewed
Sep 19, 2024
There was a problem hiding this comment.
The changes to the NFRs are an improvement. The standardization across examples is an improvement. Reviewing the changes highlights that some of the NFRs aren't very good requirements, but that is a separate problem. They weren't good before this change and the change makes them better. There is still room for improvement in the requirements themselves, but that can be a discussion for another day.
I'm fine with the PR, but @JacquesCarette will have to judge the changes to the Haskell code. (I just looked at the changes to stable.)
JacquesCarette
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3756