Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Small PR] Added Notes to Glass DD6 #933

Merged
merged 3 commits into from
Jul 23, 2018
Merged

Conversation

samm82
Copy link
Collaborator

@samm82 samm82 commented Jul 23, 2018

And changed function names from using "t1" and "t2" to the more informative "pb" and "lr"

@smiths
Copy link
Collaborator

smiths commented Jul 23, 2018

We discussed this recently in #914. I'm fine with the new names. However, we might want to revisit our variable naming in the future to carry a bit more information through stylistic conventions. For instance, we might later decide to add prefixes to variable names to give a quick mnemonic about their purpose, like T, D, I, etc. This would be like a modified Hungarian notation:

https://en.wikipedia.org/wiki/Hungarian_notation

@JacquesCarette
Copy link
Owner

Changes are fine, but there is now a conflict - can you fix please @samm82 ?

@samm82
Copy link
Collaborator Author

samm82 commented Jul 23, 2018

Done 👍

@JacquesCarette JacquesCarette merged commit 5480c6c into master Jul 23, 2018
@JacquesCarette JacquesCarette deleted the addGlassDD6Notes branch July 23, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants