Marks all but canonical paths as admin

[heddn]

This is probably a better approach for #41. One question that came up in IRC is why is DefaultHtmlRouteProvider marked as @internal.

[dawehner]

Thank you for the PR! Isn't though that exactly what \Drupal\Core\Entity\Routing\AdminHtmlRouteProvider does for you?

[heddn]

Thanks for the feedback on AdminHtmlRouteProvider. I've switched to use it instead and marked an additional route (add-form) as admin.

[Jaesin]

Since /admin paths are automatically set to TRUE, why not just let the route templates determine _admin_route status?

[heddn]

True, but if you change the paths from the defaults and don't include admin
then everything is funky. This explicitly sets what should be admin,
regardless what those paths are changed to
On Feb 18, 2016 7:15 PM, "Jaesin Mulenex" notifications@github.com wrote:

Since /admin paths are automatically set to TRUE, why not just let the
route templates determine _admin_route status?

—
Reply to this email directly or view it on GitHub
#43 (comment)
.

[Jaesin]

Funky, because it shows up in the front end theme?

[heddn]

Exactly. Those specific paths aren't themed in any good way on non admin
paths. We found another path today that I need to add to the PR. The add
page is also an admin path.
On Feb 18, 2016 7:23 PM, "Jaesin Mulenex" notifications@github.com wrote:

Funky, because it shows up in the front end theme?

—
Reply to this email directly or view it on GitHub
#43 (comment)
.

[dawehner]

I'm wondering whether we want to have a flag for that on the annotation. The behaviour for that could depend on a usecase base