Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: import get_display #1283

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix: import get_display #1283

merged 1 commit into from
Jul 25, 2024

Conversation

Yepness
Copy link
Contributor

@Yepness Yepness commented Jul 20, 2024 •
edited
Loading

Fix get display import "from bidi import get_display" and no longer from "bidi.algorithm import get_display" this PR aim to fix that issue.

@yonimadar yonimadar mentioned this pull request Jul 22, 2024
Open
@Melanee-Melanee
Copy link

Melanee-Melanee commented Jul 22, 2024 •
edited
Loading

Please install this version of python-bidi:

!pip install python-bidi==0.4.2

@vinsunkavalli
Copy link

vinsunkavalli commented Jul 22, 2024 •
edited
Loading

@Yepness I think the requirements also need to be changed to reflect that easyocr only supports newer versions of python-bidi if this change is implemented?

@Yepness
Copy link
Contributor Author

Yepness commented Jul 22, 2024 •
edited
Loading

@vinsunkavalli The current requirements reference the latest version of python-bidi, which includes the import adjustment. Therefore, there are two possible solutions:

  1. Adjust the code based on the latest version of the repository (PR).

  2. Modify the requirements to python-bidi==0.4.2 to use the currently deprecated import.

theta682
theta682 reviewed Jul 24, 2024
View reviewed changes
easyocr/easyocr.py
@@ -6,7 +6,7 @@
make_rotated_img_list, set_result_with_confidence,\
reformat_input_batched, merge_to_free
from .config import *
from bidi.algorithm import get_display
from bidi import get_display
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from bidi import get_display
try:
from bidi import get_display
except:
from bidi.algoritm import get_display

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good idea to ensure backward compability!

darrenchang
darrenchang approved these changes Jul 24, 2024
View reviewed changes
Copy link

@darrenchang darrenchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fix

easyocr/easyocr.py
@@ -6,7 +6,7 @@
make_rotated_img_list, set_result_with_confidence,\
reformat_input_batched, merge_to_free
from .config import *
from bidi.algorithm import get_display
from bidi import get_display
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good idea to ensure backward compability!

darrenchang
darrenchang approved these changes Jul 24, 2024
View reviewed changes
Copy link

@darrenchang darrenchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone approve this

This was referenced Jul 24, 2024
Closed
Closed
sagarishere
sagarishere approved these changes Jul 24, 2024
View reviewed changes
Copy link

@sagarishere sagarishere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, do this.

This is a critical issue to make the base library to be useful out of the box.

@sagarishere
Copy link

@JaidedTeam

@rkcosmos rkcosmos merged commit 3d3852d into JaidedAI:master Jul 25, 2024
@rkcosmos
Copy link
Contributor

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theta682 theta682 theta682 left review comments

@darrenchang darrenchang darrenchang approved these changes

@sagarishere sagarishere sagarishere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Yepness @Melanee-Melanee @vinsunkavalli @sagarishere @rkcosmos @theta682 @darrenchang