Fix package exports #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following entrypoints to Thyseus:
thyseus/types, which exports Thyseus types declared in the global scopethyseus/descriptors, which exports built-in system parameter descriptorsThese entrypoints were originally defined within the package.json's
exportsfield, but in order forexportsto work with TypeScript, the package consumer must set their tsconfig's--moduleResolutiontonode16ornodenext, which is not ideal for obvious reasons. See the original issue (locked for bad behavior) and the follow-up issue that describes themoduleResolutionworkaround outlined above.This PR instead adds two new sub-packages (subdirectories) each with their own package.json that point to their exports via
main/module/typesfields.